Fix types in server-side withPageAuthRequired
#512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the type definitions of
GetServerSidePropsResultWithSession
andWithPageAuthRequiredOptions
to take the props type as a generic parameter, instead of relying on[key: string]: any;
for typing properties other thanuser
. Consequently,PageRoute
andWithPageAuthRequired
were modified as well to passP
through.References
Fixes #309
Testing
This is merely a change in the type definitions, so no unit tests were added.
Checklist
main